Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(ui): fix translations #8338

Merged
merged 1 commit into from
Apr 1, 2020
Merged

enh(ui): fix translations #8338

merged 1 commit into from
Apr 1, 2020

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Feb 14, 2020

Pull Request Template

Description

some not translated sentences are emptied when an english sentence should be displayed

Fixes # (none)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 added area/translation kind/bug kind/enhancement status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Feb 14, 2020
@sc979 sc979 marked this pull request as ready for review March 20, 2020 19:35
@sc979 sc979 requested review from adr-mo and kduret April 1, 2020 13:40
@lpinsivy lpinsivy merged commit 2e2db6e into master Apr 1, 2020
@lpinsivy lpinsivy deleted the MON-translation-enhance branch April 1, 2020 14:29
sc979 added a commit that referenced this pull request Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/translation kind/bug kind/enhancement status/needs-attention The PR is on-hold. The reasons are specified in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants