Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 4790 add missing fields #8312

Merged
merged 16 commits into from
Feb 7, 2020
Merged

Mon 4790 add missing fields #8312

merged 16 commits into from
Feb 7, 2020

Conversation

victorvassilev
Copy link
Contributor

Description

Add extra fields to host and service listing via api v2

Fixes # 4790

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Run REST calls towards monitoring/services and monitoring/hosts and check payload

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@victorvassilev victorvassilev requested review from callapa, kduret and vhr and removed request for callapa February 5, 2020 14:33
@callapa
Apply suggestions from code review
07cf383 
Fixed the variables definitions that can also be null
@callapa
Apply suggestions from code review
bd9b7a7 
Fixed the variables definitions that can also be null
@callapa
Copy link
Contributor

callapa commented Feb 5, 2020

Don't forget to generate the HTML documentation.
Download https://github.com/Redocly/redoc (use nodeJS)
and lunch command:
node cli/index.js bundle --options.hideDownloadButton=true centreon-api-v2.yaml -o centreon-api-v2.html

Before doing this, please rebase from the master to avoid conflicts with the yaml file.

@cgagnaire cgagnaire added area/api kind/documentation kind/enhancement pr/internal-rd PR made by the Centreon R&D Team status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Feb 6, 2020
kduret
kduret previously approved these changes Feb 6, 2020
View reviewed changes
@kduret
Copy link
Contributor

kduret commented Feb 6, 2020

just missing html documentation.
Guide is here : https://github.com/centreon/centreon/pull/8309/files#diff-e36709718fadef4ef0aa8a8483d5496dR1

@victorvassilev victorvassilev requested a review from kduret February 6, 2020 15:42
@victorvassilev victorvassilev merged commit 11b2d00 into master Feb 7, 2020
@victorvassilev victorvassilev deleted the MON-4790-add-missing-fields branch February 7, 2020 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kduret kduret kduret approved these changes

@vhr vhr vhr approved these changes

@callapa callapa Awaiting requested review from callapa

Assignees
No one assigned
Labels
area/api kind/documentation kind/enhancement pr/internal-rd PR made by the Centreon R&D Team status/needs-attention The PR is on-hold. The reasons are specified in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victorvassilev @callapa @kduret @vhr @cgagnaire