Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix: servicegroup details displayed status #8253

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Jan 10, 2020

Pull Request Template

Description

  • Correct displayed services status
    When multiples host are linked to a same service in the servicegroup and only one host is still enabled, the status displayed in the detail view of the servicegroup is false.

image

  • Correct pagination
    The pagination displays unconsistent number of services.

image

Fixes # (support)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 merged commit fa98edf into master Jan 14, 2020
@sc979 sc979 deleted the MON-4591-status-details-correction branch January 14, 2020 12:07
sc979 added a commit that referenced this pull request Jan 21, 2020
* fix: avoid to duplicate results for each linked host

* fix: correct wrong pagination returned
sc979 added a commit that referenced this pull request Jan 21, 2020
* fix: avoid to duplicate results for each linked host

* fix: correct wrong pagination returned
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants