Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(eventlogs): allow to filter on disabled objects #8238

Merged
merged 4 commits into from
Jan 16, 2020

Conversation

lpinsivy
Copy link
Contributor

@lpinsivy lpinsivy commented Jan 6, 2020

Description

If you disable a service and you try to filter on it in "Monitoring > Event Logs > Event Logs", this filter is not used

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

On a platform with event
Disable a service
Go to "Monitoring > Event Logs > Event Logs" menu
Select this service in "Services" filter
Select a period
Click on "Apply period"
You must see event regarding your filter

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
www/class/centreonACL.class.php Outdated Show resolved Hide resolved
@lpinsivy lpinsivy requested a review from kduret January 15, 2020 09:11
@lpinsivy lpinsivy merged commit bcbb724 into master Jan 16, 2020
@lpinsivy lpinsivy deleted the MON-4643-filter-on-disabled-objects branch January 16, 2020 09:15
lpinsivy added a commit that referenced this pull request Jan 16, 2020
* fix(code): PSR2 compliance
* fix(acl): get only objects and not template
* fix(code): remove third parameter because never use
* fix(code): correct style
lpinsivy added a commit that referenced this pull request Jan 16, 2020
* fix(code): PSR2 compliance
* fix(acl): get only objects and not template
* fix(code): remove third parameter because never use
* fix(code): correct style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants