This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
enh(core): better manage exceptions and upgrade failure #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callapa
suggested changes
Jan 3, 2020
Co-Authored-By: Laurent Calvet <lcalvet@centreon.com>
kduret
suggested changes
Jan 6, 2020
sc979
force-pushed
the
MON-update-using-transactions
branch
from
January 6, 2020 13:50
822128a
to
188cfce
Compare
sc979
commented
Jan 7, 2020
callapa
approved these changes
Jan 7, 2020
kduret
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
1 - Add transactions / rollback mechanism to avoid to corrupt database on upgrade failure.
2 - Improve exception throwed and log messages on update
Fixes # (none)
Before :
Or infinite loop ->
After :
Adding the specific log file : "/var/log/centreon/upgrade.log" / called using the insertLog method with the id 4 :
Type of change
Target serie
How this pull request can be tested ?
Create condition for an exception to be throwed and check that the proper message is displayed in the IHM.
Checklist
Community contributors & Centreon team
Centreon team only