Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Migrate centreon web to use centreon-ui's components (target: master) #8207

Merged
merged 6 commits into from
Jan 7, 2020

Conversation

Thebarda
Copy link
Contributor

@Thebarda Thebarda commented Dec 23, 2019

Pull Request Template

Description

@centreon/react-components was renamed to @centreon/ui and centreon is still using @centreon/react-components. This PR integrate new UI components repository (@centreon/ui) instead of the old one (@centreon/react-components`)

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Breadcrumb, Extension Manager and Navigation menu currently use centreon-ui components.
Through the navigation menu, go to Extension Manager then install an extension.
Use the breadcrumb by clicking on his own links.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@Thebarda Thebarda requested review from bdauria and kduret December 23, 2019 15:13
@Thebarda Thebarda changed the title Migrate centreon web to use centreon-ui's components Migrate centreon web to use centreon-ui's components (target: master) Dec 23, 2019
@bdauria
Copy link
Contributor

bdauria commented Dec 24, 2019

waiting for https://jenkins.centreon.com/job/centreon-web/view/change-requests/job/PR-8207/ to be successfully built, otherwise LGTM.

@Thebarda Thebarda merged commit 3583096 into master Jan 7, 2020
@Thebarda Thebarda deleted the rename_@centreon/react-components-to_@centreon/ui branch January 28, 2021 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants