fix(topcounter): use session cache to store top counter hosts/services results #8189

garnier-quentin · 2019-12-11T09:35:24Z

Pull Request Template

Description

On huge platform with many users (around 200), top counters services/hosts slows overall database real-time performances.
The best solution should have a configuration for read-only mariadb/mysql replicas. Like that we could have many users and we don't slow real time database for centreon-broker. First, It's important for top counters, services monitoring and some widgets. For configuration and graphs, we could do it after.
That solution will take some time. So i have done a patch. It fixes following issue:

my refresh time 'AjaxTimeReloadStatistic' is 60 but react calls topcounters services and hosts every 30 seconds
if we have multiple tabs on your browser with the same session, it calls top counters too many times.

I use the session cache to solve the issue.

Fixes # (issue)

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

How this pull request can be tested ?

If you call the top counter 2 times in a row, it should provide the same result (there is the 'time' attribute).

Checklist

Community contributors & Centreon team

I followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

I have made sure that the unit tests related to the story are successful.
I have made sure that unit tests cover 80% of the code written for the story.
I have made sure that acceptance tests related to the story are successful (local and CI)

www/api/internal.php

www/api/class/centreon_topcounter.class.php

www/class/centreonSession.class.php

www/include/configuration/configNagios/DB-Func.php

www/include/configuration/configGenerate/xml/moveFiles.php

sc979 · 2020-02-24T09:15:34Z

www/api/class/centreon_topcounter.class.php

@@ -612,6 +619,11 @@ public function getServicesStatus()
            throw new \RestUnauthorizedException("You're not authorized to access resource datas");
        }

+        if (isset($_SESSION['topCounterServiceStatus']) && 


a function will avoid to duplicate lines 556->559 & 622->625

…centreon into topcounter-performance

…s results (#8189) * use session cache to store top counter hosts/services results * resolve comments review * enh(performance): session size fix * fix(topcounter): manage reviews * fix topcounters session errors * fix timezone * replace deprecated method * remove useless request to get configuration poller main.cfg * Update moveFiles.php * Update moveFiles.php Co-authored-by: qgarnier <garnier.quentin@gmail.com> Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com> Co-authored-by: Kevin Duret <duret.kevin@gmail.com>

…s results (#8189) * use session cache to store top counter hosts/services results * resolve comments review * enh(performance): session size fix * fix(topcounter): manage reviews * fix topcounters session errors * fix timezone * replace deprecated method * remove useless request to get configuration poller main.cfg * Update moveFiles.php * Update moveFiles.php Co-authored-by: qgarnier <garnier.quentin@gmail.com> Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com> Co-authored-by: Kevin Duret <duret.kevin@gmail.com> Conflicts: www/class/centreon.class.php

* enh(apiv2): add extra fields to host read endpoint Resolves: MON-4943 * fix(code): Clean switch case service monitoring (#8285) * fix(code): dedicated meta event console does not exist anymore * fix(code): scheduling queue console does not exist anymore * fix(code): merge some cases Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com> * fix(remote-server): fix import with strict mode (#7944) Refs: MON-7944 * Update src/Centreon/Domain/Monitoring/Host.php Co-Authored-By: Kevin Duret <kduret@centreon.com> * Update src/Centreon/Domain/Monitoring/Host.php Co-Authored-By: Kevin Duret <kduret@centreon.com> * doc(api): document how to generate html api documentation (#8394) * fix(topcounter): use session cache to store top counter hosts/services results (#8189) * use session cache to store top counter hosts/services results * resolve comments review * enh(performance): session size fix * fix(topcounter): manage reviews * fix topcounters session errors * fix timezone * replace deprecated method * remove useless request to get configuration poller main.cfg * Update moveFiles.php * Update moveFiles.php Co-authored-by: qgarnier <garnier.quentin@gmail.com> Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com> Co-authored-by: Kevin Duret <duret.kevin@gmail.com> * enh(config): prepare anomalydetection module (#8321) * enh(config): prepare anomalydetection module * Update service.class.php * fix(config): remove dead code Co-authored-by: qgarnier <garnier.quentin@gmail.com> * enh(apiv2): add extra fields to host read endpoint Resolves: MON-4943 * Update src/Centreon/Domain/Monitoring/Host.php Co-Authored-By: Kevin Duret <kduret@centreon.com> * Update src/Centreon/Domain/Monitoring/Host.php Co-Authored-By: Kevin Duret <kduret@centreon.com> * remove api html doc Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com> Co-authored-by: Kevin Duret <kduret@centreon.com> Co-authored-by: qgarnier <garnier.quentin@gmail.com> Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com> Co-authored-by: Kevin Duret <duret.kevin@gmail.com>

use session cache to store top counter hosts/services results

43108b3

loiclau previously approved these changes Dec 17, 2019

View reviewed changes

cgagnaire added area/performance kind/enhancement labels Dec 17, 2019

cgagnaire changed the title ~~use session cache to store top counter hosts/services results~~ fix(topcounter): use session cache to store top counter hosts/services results Dec 17, 2019

kduret reviewed Dec 21, 2019

View reviewed changes

www/api/internal.php Outdated Show resolved Hide resolved

resolve comments review

f3cec38

cgagnaire requested review from kduret and callapa January 16, 2020 12:47

Merge branch 'master' into topcounter-performance

e51f9c4

kduret suggested changes Feb 4, 2020

View reviewed changes

www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved

www/api/class/centreon_topcounter.class.php Show resolved Hide resolved

www/api/class/centreon_topcounter.class.php Show resolved Hide resolved

www/class/centreonSession.class.php Outdated Show resolved Hide resolved

callapa reviewed Feb 4, 2020

View reviewed changes

www/class/centreonSession.class.php Outdated Show resolved Hide resolved

cgagnaire added pr/internal-ps PR made by the Centreon ProServices Team status/needs-attention The PR is on-hold. The reasons are specified in the PR labels Feb 6, 2020

garnier-quentin added 2 commits February 11, 2020 09:46

Merge branch 'master' into topcounter-performance

6d46a9b

enh(performance): session size fix

42467e6

garnier-quentin dismissed loiclau’s stale review via 42467e6 February 11, 2020 10:03

fix(topcounter): manage reviews

5a14023

sc979 reviewed Feb 14, 2020

View reviewed changes

www/include/configuration/configNagios/DB-Func.php Outdated Show resolved Hide resolved

sc979 reviewed Feb 14, 2020

View reviewed changes

www/include/configuration/configNagios/DB-Func.php Outdated Show resolved Hide resolved

sc979 previously approved these changes Feb 14, 2020

View reviewed changes

sc979 requested review from kduret, callapa and loiclau February 14, 2020 09:38

fix topcounters session errors

fc32c01

garnier-quentin dismissed sc979’s stale review via fc32c01 February 17, 2020 15:23

fix timezone

7ebb682

sc979 reviewed Feb 24, 2020

View reviewed changes

www/include/configuration/configGenerate/xml/moveFiles.php Outdated Show resolved Hide resolved

replace deprecated method

32a0d80

sc979 reviewed Feb 24, 2020

View reviewed changes

garnier-quentin added 2 commits February 24, 2020 10:19

remove useless request to get configuration poller main.cfg

bb368e3

Merge branch 'topcounter-performance' of https://github.com/centreon/…

b36e554

…centreon into topcounter-performance

sc979 previously approved these changes Feb 24, 2020

View reviewed changes

Update moveFiles.php

cab300a

kduret dismissed sc979’s stale review via cab300a March 5, 2020 08:42

Update moveFiles.php

1696a96

kduret approved these changes Mar 5, 2020

View reviewed changes

sc979 approved these changes Mar 5, 2020

View reviewed changes

cgagnaire merged commit 3b8df36 into master Mar 5, 2020

cgagnaire deleted the topcounter-performance branch March 5, 2020 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(topcounter): use session cache to store top counter hosts/services results #8189

fix(topcounter): use session cache to store top counter hosts/services results #8189

garnier-quentin commented Dec 11, 2019

sc979 Feb 24, 2020

fix(topcounter): use session cache to store top counter hosts/services results #8189

fix(topcounter): use session cache to store top counter hosts/services results #8189

Conversation

garnier-quentin commented Dec 11, 2019

Pull Request Template

Description

Type of change

Target serie

How this pull request can be tested ?

Checklist

Community contributors & Centreon team

Centreon team only

sc979 Feb 24, 2020

Choose a reason for hiding this comment