Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(chore) replace centcore by gorgone #8172

Merged
merged 14 commits into from
Dec 18, 2019
Merged

enh(chore) replace centcore by gorgone #8172

merged 14 commits into from
Dec 18, 2019

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Dec 4, 2019 •
edited
Loading

Description

I want Centreon Gorgone to be installed when installing Centreon Web
I want centcore to disappear forever from the source code

Information

Modify centreon-web SPEC template to include a dependance with centreon-gorgone
Add missing perl-CryptX dep in repos. 
Delete all centcore source code from Centreon project,
Delete centcore source code references in SPEC templates.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@loiclau loiclau marked this pull request as ready for review December 9, 2019 08:45
kduret
kduret reviewed Dec 9, 2019
View reviewed changes
doc/fr/faq/remote_server.rst Outdated Show resolved Hide resolved
kduret
kduret reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove centcore entries in documentation (eg: restart of centcore's service)
But is it the purpose of this PR ?

kduret
kduret suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe this PR and add a proper title

sc979
sc979 reviewed Dec 10, 2019
View reviewed changes
doc/en/faq/remote_server.rst
Check that **/etc/centreon** includes the following files and that they are not empty:

* instCentCore.conf
* instCentPlugins.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ...Plugins.conf not required anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No only instCentWeb.conf is needed for modules and source update
I change all module to use only instCentWeb.conf (see associated PR for modules)

doc/en/upgrade/from_sources.rst Outdated Show resolved Hide resolved
doc/fr/faq/remote_server.rst Show resolved Hide resolved
@loiclau loiclau changed the title Mon 4505 gorgone dependance enh(chore) replace centcore by gorgone Dec 12, 2019
@loiclau loiclau changed the base branch from master to MON-gorgone-integration December 12, 2019 14:09
@loiclau
Copy link
Contributor Author

loiclau commented Dec 16, 2019

An other branch was created for documentation: https://github.com/centreon/centreon/tree/MON-4505-update-doc-for-gorgone

kduret
kduret approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me once conflicts are resolved

@loiclau loiclau merged commit 47d3f41 into MON-gorgone-integration Dec 18, 2019
@loiclau loiclau deleted the MON-4505-gorgone-dependance branch December 18, 2019 13:37
sc979 added a commit that referenced this pull request Mar 18, 2020
@sc979 @loiclau
@cgagnaire @callapa @bdauria @lpinsivy @kduret
enh(core): replace centcore with gorgoned (#8414)
985c8ba 
* enh(core): generate centreon gorgone configuration file (#8160)

* enh(core): add gorgone configuration file generation

* fix: folder paths

* fix(core): naming of file and field type

* enh(core): update configuration file to take in account last modif

* fix(core): correct path to private key

* enh(core): add nodes module

* enh(core): store stats in cache dir

* enh(core): enable broker stats collection

* enh(poller) Update poller form to manage gorgone (#8184)

* enh(gorgone) Update config form to manage gorgone options  (#8197)

* enh(chore) replace centcore by gorgone (#8172)

* remove centcore perl script (#8209)

* fix(UI): do not display gorgone options on central's form (#8206)

* fix(UI): do not display gorgone options on central

* remove duplicated code (#8215)

* enh(admin): adapt broker stats page to new folder tree (#8216)

* enh(core): update script to manage gorgone configuration file (#8229)

* enh: exception management

* enh(update): generate gorgone conf file on update

* fix(translation): avoid empty gettext translation

* enh(core): Add a yaml configuration loader (#8270)

* MON-4737 enh(core): split gorgone configuration in different files (#8276)

* enh(core): adapt upgrade script to latest modifications (#8284)

* adapt update script

* enh: add more check brefore trying to create the conf files

* fix: correct path in the template

* enh(core): update gorgone configuration files (#8293)

* update configuration location

* enh(gorgone): Added API to communicate with the Gorgone server (#8294)

* enh(install): fix default keys pathes (#8302)

* fix db name configuration template

* replace remote data folder

* fix rest api test

* enh(UI): Add nowrap style to badge class - from aladdinchan (#8314)

* fix(ui): Add hash:8 suffix to font files to avoid asset conflicts and optimize Webpack config (#8305)

* Mon 4640 remove deprecated engine fields (#8233)

* fix(CI): add new tests to clapi diff

* fix(core): source install (#8396)

* enh(core): add gorgone user and copy ssh keys

* fix(api): fix options retrieval issue (#8412)

* fix(core): manage the gorgone configuration files (#8400)

* fix(core): duplicate SSH key on source upgrade (#8421)

Co-authored-by: loiclau <loic.lau@gmail.com>
Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Co-authored-by: Bruno d'Auria <bdauria@centreon.com>
Co-authored-by: Matthieu Kermagoret <mkermagoret@centreon.com>
Co-authored-by: Laurent Pinsivy <lpinsivy@centreon.com>
Co-authored-by: Kevin Duret <duret.kevin@gmail.com>
Co-authored-by: Laurent Calvet <laurent@callapa.com>
Co-authored-by: Kevin Duret <kduret@centreon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sc979 sc979 sc979 left review comments

@lpinsivy lpinsivy lpinsivy left review comments

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
area/install kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loiclau @lpinsivy @kduret @sc979 @cgagnaire