This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(acl): fix calculation of acls on services #8146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
approved these changes
Nov 25, 2019
| @@ -534,14 +531,14 @@ function getMyHostServicesByName($host_id = null) | |||
| */ | |||
| function getMetaServices($resId, $db, $metaObj) | |||
| { | |||
| $sql = "SELECT meta_id FROM acl_resources_meta_relations WHERE acl_res_id = {$db->escape($resId)}"; | |||
| $sql = "SELECT meta_id FROM acl_resources_meta_relations WHERE acl_res_id = " . (int) $resId; | |||
There was a problem hiding this comment.
why not prepare the query here ?
Nohzoh
approved these changes
Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ACLs on service were not calculated (only on 19.04.5), so non-admin users could not see any services.
Refs: MON-4530
Type of change
Target serie