Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(ldap): correct double slashes in the saved DN - for 19.04.x #8121

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Nov 13, 2019

Pull Request Template

Description

The DN is escaped twice before inserting its value in the DB.
Resulting on a first successfull connection and the impossibility to connect again using the account.
As the ldapSearch method will use a DN which doesn't exist

Fixes # (none)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Add to your LDAP specific escaped characters (like : " , ") and manually import a contact.
The contact will be displayed in the list, but in the DB, the contact_ldap_dn will have two slashes.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 force-pushed the MON-4450-for-19-04-ldap-user-dn-escape-behavior branch from 15ed7c1 to 0eabc2b Compare November 14, 2019 20:03
@sc979 sc979 merged commit 789dacb into 19.04.x Nov 25, 2019
@sc979 sc979 deleted the MON-4450-for-19-04-ldap-user-dn-escape-behavior branch November 25, 2019 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants