Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(BE): replace order filter's regexp using whitelist #8094

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Nov 6, 2019

Pull Request Template

Description

Replace the regexp filter sanitize on the $order parameter with a whitelist.
Correct coding style for the CI

Fixes # (CI - 2.8.x)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

1 - test the "order" of the status > monitoring pages

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 self-assigned this Nov 6, 2019
@sc979 sc979 force-pushed the MON-4187-for-2-8-remove-regexp-using-whitelist branch from 47ffda1 to f12861f Compare November 6, 2019 15:16
@sc979 sc979 merged commit f425aef into 2.8.x Nov 6, 2019
@sc979 sc979 deleted the MON-4187-for-2-8-remove-regexp-using-whitelist branch November 6, 2019 15:57
callapa pushed a commit that referenced this pull request Nov 12, 2019
* enh(UI): replace regexp by whitelist

* fix(CI): sonar coding style issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants