Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

feat(api): Add some new parameters #8085

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

smutel
Copy link
Contributor

@smutel smutel commented Nov 1, 2019

Pull Request Template

Description

Add the capability to set parameter "acknowledgement timeout" of host through the API.
Add other missing parameters.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

curl -s -H "centreon-auth-token:$CENTREON_TOKEN" -H "Content-Type: application/json" -d '{"action":"setparam", "object":"HOST", "values": "tf_host;acknowledgement_timeout;10"}' "${CENTREON_URL}/centreon/api/index.php?action=action&object=centreon_clapi"

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@smutel smutel force-pushed the add-param-ack-timeout branch from 7de3e0b to 0b6c30f Compare November 2, 2019 17:55
@smutel smutel changed the title feat(api): Add new parameter acknowledgement_timeout feat(api): Add some new parameters Nov 2, 2019
@kduret
Copy link
Contributor

kduret commented Nov 5, 2019

Thanks for contribution.
We'll try to apply it on centreon-web-19.10.2

@kduret kduret merged commit 533810d into centreon:master Dec 3, 2019
kduret pushed a commit that referenced this pull request Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants