This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(api) return curve metric name for map #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
approved these changes
Oct 25, 2019
| @@ -122,6 +122,7 @@ public function getData($rows = 200) | |||
| "warn" => null | |||
| ); | |||
| $info['legend'] = str_replace('\\\\', '\\', $metric['metric_legend']); | |||
| $info['metric_name'] = !empty($metric['ds_name']) ? $metric['ds_name'] : $info['legend']; | |||
There was a problem hiding this comment.
couldn't you use a null coalescent ternary instead
|
Please include a short description of the PR. |
kduret
approved these changes
Oct 28, 2019
loiclau
changed the title
|
Can this be merged before it's tested :) ? As describe in the process |
loiclau
added a commit
that referenced
this pull request
Nov 5, 2019
loiclau
added a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
To fix STUDIO-2315, we need to add additional information
Solution is to add a new field to the response, which will always be the name of the associated metric, so we have no possible regressions.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team
Centreon team only