Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(meta): remove unused radio button in meta configuration #7992

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Oct 16, 2019

Pull Request Template

Description

image (1)

Remove this unused radio button

Fixes NONE

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • [] 18.10.x
  • [] 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Configure a META service.
When you add your metrics to the META the radio button should not appear and the functionality is not broker

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@adr-mo adr-mo merged commit 7628e28 into master Oct 25, 2019
@adr-mo adr-mo deleted the remove-dead-code branch October 25, 2019 17:37
adr-mo added a commit that referenced this pull request Oct 25, 2019
* fix(meta): remove unused radio button in meta configuration

* fix(meta): take feedback into account
adr-mo added a commit that referenced this pull request Oct 25, 2019
* fix(meta): remove unused radio button in meta configuration

* fix(meta): take feedback into account
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants