Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(downtimes): apply dt on resources linked to a poller #7955

Merged
merged 5 commits into from
Oct 10, 2019

Conversation

lpinsivy
Copy link
Contributor

@lpinsivy lpinsivy commented Oct 10, 2019

Description

You can't set a downtime on a Poller using the popin form on :
"Monitoring > Downtimes > Downtimes" and selecting "Pollers", as no selectbox is available

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Create a downtime and select a poller.
Then check the centengine.log of the selected poller and check that the command has been sent to centengine.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy lpinsivy changed the title fix(downtimes): applay dt on resources linked to a pollers fix(downtimes): apply dt on resources linked to a pollers Oct 10, 2019
@kduret
Copy link
Contributor

kduret commented Oct 10, 2019

don't forget to fill the description ;)

www/include/monitoring/downtime/AddDowntime.php Outdated Show resolved Hide resolved
www/include/monitoring/downtime/AddDowntime.php Outdated Show resolved Hide resolved
www/include/monitoring/downtime/AddDowntime.php Outdated Show resolved Hide resolved
@sc979
Copy link
Contributor

sc979 commented Oct 10, 2019

@kduret -> I've updated the description. Is it enough ?

lpinsivy and others added 3 commits October 10, 2019 14:47
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
@lpinsivy lpinsivy changed the title fix(downtimes): apply dt on resources linked to a pollers fix(downtimes): apply dt on resources linked to a poller Oct 10, 2019
@lpinsivy lpinsivy merged commit dd7d75c into master Oct 10, 2019
@lpinsivy lpinsivy deleted the MON-4236-unable-to-add-dt-on-sg branch October 10, 2019 14:38
lpinsivy added a commit that referenced this pull request Oct 10, 2019
* fix(downtime): allow to apply dt on resources linked to a poller
lpinsivy added a commit that referenced this pull request Oct 10, 2019
* fix(downtime): allow to apply dt on resources linked to a poller
@lpinsivy lpinsivy mentioned this pull request Oct 14, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants