This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(update): take into account the removal of older conf.php #7952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
approved these changes
Oct 9, 2019
| $sth->bindValue(':is_removeable', $this->moduleConfiguration['is_removeable'], \PDO::PARAM_STR); | ||
| $sth->bindValue(':infos', $this->moduleConfiguration['infos'], \PDO::PARAM_STR); | ||
| $sth->bindValue(':author', $this->moduleConfiguration['author'], \PDO::PARAM_STR); | ||
| $sth->bindValue(':svc_tools', $this->moduleConfiguration['svc_tools'] ?? '0', \PDO::PARAM_STR); |
There was a problem hiding this comment.
couldn't you check this key/value when modulecnofiguration is set ?
There was a problem hiding this comment.
This has been set in the bindValue for now, but those two values will be removed in next versions because no longer used...
kduret
approved these changes
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Take into account the removal of older conf.php files that were located in the upgrade directories of te modules (EMS)
Fixes NONE
Type of change
Target serie
How this pull request can be tested ?
Upgrade from the 19.04.x to the 19.10.0 with some EMS modules installed.
The WEB upgrade in Administration -> Extensions -> Manager should work
Checklist
Community contributors & Centreon team
Centreon team only