Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Ease widgets installation during web installation process #7890

Merged
merged 10 commits into from
Oct 2, 2019

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Sep 30, 2019

Description

For a few days now, Centreon has dependencies on the widgets.
It could be great to give the opportunity to the user to install the widgets (web part) at the end of the web installation (already done for centreon-license-manager, centreon-pp-manager, centreon-autodiscovery-server ...)

This PR aims also to standardize the style (checkboxes) with the latest version of centreon

Fixes None

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

When I get for the first time to the last step of the web installation
All the checkboxes should be checked.

Use case 1

  • I directly click on “Install” button, which will trigger the installation of all modules and widgets
  • The “Install” button should turn grey and the text changes from “Install” to “Installing…
  • Once installation done, the button should be replaced by the “Next” button and all checkboxes are green.
  • If I hit the “Refresh” button or F5, all the checkboxes should be green and the “Next” button should be there too.

Use case 2

  • I uncheck some of the modules/widgets. The install button should be kept
  • I click on the “Install” button
  • The “Install” button should turn grey and the text changes from “Install” to “Installing…
  • Once installation done, the button should be replaced by the “Next” button and all selected checkboxes should be green.

Two choices here:

  • I click on Next to finalize the installation
  • I click on other checkboxes to install other modules / widgets, then the install should appear again and so on…

Use case 3

  • I uncheck all the modules/widgets
  • The “Next” button should appear

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@adr-mo adr-mo changed the title Mon 4159 web install widgets Ease widgets installation during web installation process Sep 30, 2019
@adr-mo adr-mo requested a review from kduret September 30, 2019 13:43
@adr-mo
Copy link
Contributor Author

adr-mo commented Oct 2, 2019

Hi @kduret I've pushed one commit in order to upgrade the style of the checkboxe during the upgrade process (step when asking to join the stats program)

@adr-mo
Copy link
Contributor Author

adr-mo commented Oct 2, 2019

Thanks @callapa I've committed your suggestion ! 💯

@adr-mo adr-mo force-pushed the MON-4159-web-install-widgets branch from 8c9fc65 to da9996d Compare October 2, 2019 14:24
@adr-mo adr-mo merged commit 54f0be9 into master Oct 2, 2019
@adr-mo adr-mo deleted the MON-4159-web-install-widgets branch October 2, 2019 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants