Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(db): allow remote server config to be loaded with mysql strict mode enabled #7887

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

cgagnaire
Copy link

Description

This PR aims to allow Remote Server .infile configuration files to be loaded when MySQL strict mode is enabled on the Remote Server database.

The "LOAD DATA INFILE" has to be replaced by "LOAD DATA LOCAL INFILE".
The "MYSQL_ATTR_LOCAL_INFILE" option of PDO needs to be set to "true".

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Before this patch, try to export and import Remote Server configuration when strict mode is enabled on the Remote Server database.
It will result with the following error :

SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: 'NULL' for column `centreon`.`giv_components_template`.`host_id` at row 1

After the patch, no error is rised.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 merged commit 1a74152 into master Sep 30, 2019
@sc979 sc979 deleted the remote-server-load-data branch September 30, 2019 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants