Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(status details): Fix hide password in command line for 2.8.x (#7414) #7883

Merged
merged 4 commits into from
Oct 4, 2019

Conversation

lpinsivy
Copy link
Contributor

Description

  • Change method + add default message if can't apply method
  • Add PDO bindParam method for SQL requests
  • Fix PSR2

Fixes #7414
Based on #7859

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Create different checks commands
Describe custom macros as password type in host, HTPL, service and STPL
Verify in service status details page if all passwords are replaced by '***'

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy lpinsivy changed the title fix(status details): Fix hide password in command line (#7414) fix(status details): Fix hide password in command line for 2.8.x (#7414) Sep 26, 2019
@adr-mo adr-mo requested a review from kduret September 27, 2019 12:16
@lpinsivy lpinsivy force-pushed the MON-3694-macro-password-are-not-hidden-2.8.x branch from 9a66643 to b4bc97f Compare October 3, 2019 12:32
Co-Authored-By: Laurent Calvet <lcalvet@centreon.com>
@kduret kduret merged commit 5d08c7f into 2.8.x Oct 4, 2019
@kduret kduret deleted the MON-3694-macro-password-are-not-hidden-2.8.x branch October 4, 2019 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants