Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(BE): better handling PNG export failure #7823

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Aug 30, 2019

Pull Request Template

Description

Fixing the displayerror method to avoid the blank page / crash of the browser
Enhancing messages displayed
Creating a PNG with the error message instead ot the RRD graph

Fixes # (https://github.com/centreon/centreon/pull/7822) requested changes

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 requested review from callapa and kduret August 30, 2019 12:37
@sc979 sc979 mentioned this pull request Aug 30, 2019
16 tasks
@sc979 sc979 changed the title fix(BE): thrown exception fix(BE): better handling PNG export failure Aug 30, 2019
@sc979 sc979 force-pushed the MON-graph-query-execute branch from 492f5f0 to d15acaf Compare August 30, 2019 16:17
@sc979 sc979 requested a review from callapa August 30, 2019 16:19
@sc979 sc979 requested a review from loiclau September 2, 2019 09:03
@sc979 sc979 merged commit 4031ca1 into 19.04.x Sep 3, 2019
@sc979 sc979 deleted the MON-graph-query-execute branch September 3, 2019 09:47
sc979 added a commit that referenced this pull request Sep 3, 2019
* fix(BE): exported PNG should display the error
* fix(BE): thrown exception
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants