Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

MON 4122 Update Strict mode doc and repo link #7806

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Aug 27, 2019

Pull Request Template

Description

Replace the 19.04 centreon-release repo with the 19.10
Correct the SQL Strict Mode notice
Minor correction in french

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 requested review from lpinsivy and thiuyendang August 27, 2019 09:40
Copy link
Contributor

@lgcosta lgcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just comment about strict mode information

@sc979
Copy link
Contributor Author

sc979 commented Aug 27, 2019

@lgcosta , I replied to each of them ;)

@sc979 sc979 merged commit 8e8381b into master Aug 27, 2019
@sc979 sc979 deleted the MON-4122-correct-19-10-doc branch August 27, 2019 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants