Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(UI): labels in graph alignment #7805

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

EdytaSki
Copy link
Contributor

@EdytaSki EdytaSki commented Aug 27, 2019

Pull Request Template

Description

Steps to reproduce the issue:

Monitoring > Status Details > Services

Click on a service with multiple metrics

Scroll down

Put you mouse on the graph

Describe the results you received:

Labels are centered, leading to something difficult to read and the display is different than when we display it under "Monitoring > Performances > Graphs"

image

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (centreon/centreon#5274)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@loiclau loiclau merged commit 117aa18 into master Aug 30, 2019
@loiclau loiclau deleted the MON-4123-labels-in-graphs-not-aligned branch August 30, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants