Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

core(rrd) move global rrd cache option #7791

Merged
merged 32 commits into from
Sep 20, 2019
Merged

core(rrd) move global rrd cache option #7791

merged 32 commits into from
Sep 20, 2019

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Aug 21, 2019

Pull Request Template

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

www/class/centreonConfigCentreonBroker.php Show resolved Hide resolved
www/class/centreonConfigCentreonBroker.php Outdated Show resolved Hide resolved
www/class/centreonConfigCentreonBroker.php Outdated Show resolved Hide resolved
www/class/centreonConfigCentreonBroker.php Outdated Show resolved Hide resolved
www/class/centreonConfigCentreonBroker.php Outdated Show resolved Hide resolved
www/include/common/javascript/centreon/brokerConfig.js Outdated Show resolved Hide resolved
www/install/insertBaseConf.sql Show resolved Hide resolved
www/install/php/Update-19.10.0-beta.3.php Outdated Show resolved Hide resolved
www/install/php/Update-19.10.0-beta.3.php Outdated Show resolved Hide resolved
www/install/php/Update-19.10.0-beta.3.php Outdated Show resolved Hide resolved
@sc979
Copy link
Contributor

sc979 commented Aug 21, 2019

yeahYeah, you'll hate me ;)

loiclau and others added 4 commits August 22, 2019 08:52
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be better if cache option appeared before link :
image

@loiclau loiclau merged commit 615961b into master Sep 20, 2019
@loiclau loiclau deleted the MON-4035-rrd-broker branch September 20, 2019 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants