Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix: GMT is null if user don't choose one #7766

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

adrien2612
Copy link
Contributor

Pull Request Template

Description

If users don't choose a timezone then the GMT will be set to null

Fixes # (issue)
Needed this fix to allow the export of the column Last check from service and host monitoring widgets

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

By trying to export either service or host monitoring widget while including Last check column

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

Copy link
Contributor

@quanghungb quanghungb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated lines ?

www/class/centreonGMT.class.php Outdated Show resolved Hide resolved
@adrien2612 adrien2612 requested review from sc979 and quanghungb August 8, 2019 09:19
@adrien2612 adrien2612 merged commit 49738a2 into master Aug 12, 2019
@adrien2612 adrien2612 deleted the MON-4092-fix-GMT-null-by-default branch August 12, 2019 12:26
adrien2612 added a commit that referenced this pull request Aug 22, 2019
* fix: GMT is null if user don't choose one
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants