Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(remote-server): improve centreonworker logging #7712

Merged
merged 3 commits into from
Sep 20, 2019
Merged

enh(remote-server): improve centreonworker logging #7712

merged 3 commits into from
Sep 20, 2019

Conversation

cgagnaire
Copy link

@cgagnaire cgagnaire commented Jul 18, 2019

Description

Enhances CentreonWorker logging.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Nothing particular, just launch an export/import process.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could extract (new \DateTime())->format("Y-m-d H:i:s") to a separated function
or use directly date("Y-m-d H:i:s")

src/CentreonRemote/Application/Clapi/CentreonWorker.php Outdated Show resolved Hide resolved
@lpinsivy lpinsivy changed the title enh(remote): enh centreonworker logging enh(remote-server): improve centreonworker logging Jul 18, 2019
@lpinsivy lpinsivy added the status/in-backlog A dev will begin to work on your modifications soon label Jul 18, 2019
@kduret kduret merged commit 0ac59eb into centreon:master Sep 20, 2019
kduret pushed a commit that referenced this pull request Sep 20, 2019
* enh(remote): enh centreonworker logging

* enh(remote): delete DateTime

* enh(remote): replace datetime object by date function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/remote-server kind/enhancement status/in-backlog A dev will begin to work on your modifications soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants