This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
fix(remote): fix enableremote parameters parsing and setting #7711
Merged
lpinsivy
merged 3 commits into
centreon:master
from
cgagnaire:fix-centreonremoteserver-parameters-parsing
Jul 25, 2019
Merged
fix(remote): fix enableremote parameters parsing and setting #7711
lpinsivy
merged 3 commits into
centreon:master
from
cgagnaire:fix-centreonremoteserver-parameters-parsing
Jul 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduret
suggested changes
Jul 18, 2019
kduret
approved these changes
Jul 18, 2019
lpinsivy
approved these changes
Jul 18, 2019
lpinsivy
added
area/remote-server
area/api
kind/bug
status/in-backlog
A dev will begin to work on your modifications soon
labels
Jul 18, 2019
lpinsivy
pushed a commit
that referenced
this pull request
Jul 25, 2019
* fix(remote): fix enableremote parameters parsing and setting * fix(remote): remote DateTime, add parameter description * fix(remote): replace datetime object by date function
lpinsivy
pushed a commit
that referenced
this pull request
Jul 25, 2019
* fix(remote): fix enableremote parameters parsing and setting * fix(remote): remote DateTime, add parameter description * fix(remote): replace datetime object by date function Conflicts: src/CentreonRemote/Application/Clapi/CentreonRemoteServer.php
UrBnW
reviewed
Jul 25, 2019
lpinsivy
added a commit
that referenced
this pull request
Jul 25, 2019
lpinsivy
added a commit
that referenced
this pull request
Jul 25, 2019
lpinsivy
added a commit
that referenced
this pull request
Jul 25, 2019
kduret
pushed a commit
that referenced
this pull request
Jul 31, 2019
* fix(remote): fix enableremote parameters parsing and setting * fix(remote): remote DateTime, add parameter description * fix(remote): replace datetime object by date function
kduret
pushed a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/api
area/remote-server
kind/bug
status/in-backlog
A dev will begin to work on your modifications soon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes parameters string parsing to allow use of fqdn and ip.
Makes 'Notifying Master' process more verbose to understand where the failed action can come from.
Adds better logging.
Handles date/time better so its actually the date and time at the log printing.
Type of change
Target serie
How this pull request can be tested ?
Try to enable a remote with the following "url" list : https://regex101.com/r/IGDtNg/2, and see how it is parsed.Checklist
Community contributors & Centreon team
Centreon team only