Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(remote): fix enableremote parameters parsing and setting #7711

Merged
merged 3 commits into from
Jul 25, 2019
Merged

fix(remote): fix enableremote parameters parsing and setting #7711

merged 3 commits into from
Jul 25, 2019

Conversation

cgagnaire
Copy link

@cgagnaire cgagnaire commented Jul 18, 2019

Description

Fixes parameters string parsing to allow use of fqdn and ip.
Makes 'Notifying Master' process more verbose to understand where the failed action can come from.
Adds better logging.
Handles date/time better so its actually the date and time at the log printing.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Try to enable a remote with the following "url" list : https://regex101.com/r/IGDtNg/2, and see how it is parsed.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy lpinsivy added area/remote-server area/api kind/bug status/in-backlog A dev will begin to work on your modifications soon labels Jul 18, 2019
@lpinsivy lpinsivy merged commit 0c09cd0 into centreon:master Jul 25, 2019
lpinsivy pushed a commit that referenced this pull request Jul 25, 2019
* fix(remote): fix enableremote parameters parsing and setting
* fix(remote): remote DateTime, add parameter description
* fix(remote): replace datetime object by date function
lpinsivy pushed a commit that referenced this pull request Jul 25, 2019
* fix(remote): fix enableremote parameters parsing and setting
* fix(remote): remote DateTime, add parameter description
* fix(remote): replace datetime object by date function

Conflicts:
	src/CentreonRemote/Application/Clapi/CentreonRemoteServer.php
lpinsivy added a commit that referenced this pull request Jul 25, 2019
lpinsivy added a commit that referenced this pull request Jul 25, 2019
lpinsivy added a commit that referenced this pull request Jul 25, 2019
kduret pushed a commit that referenced this pull request Jul 31, 2019
* fix(remote): fix enableremote parameters parsing and setting
* fix(remote): remote DateTime, add parameter description
* fix(remote): replace datetime object by date function
kduret pushed a commit that referenced this pull request Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api area/remote-server kind/bug status/in-backlog A dev will begin to work on your modifications soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants