This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
add escapeshellarg to nagios_bin binary passed to shell_exec #7694
Merged
sc979
merged 3 commits into
master
from
MON-3968-escape-nagios-path-and-poller-id-master
Jul 15, 2019
Merged
add escapeshellarg to nagios_bin binary passed to shell_exec #7694
sc979
merged 3 commits into
master
from
MON-3968-escape-nagios-path-and-poller-id-master
Jul 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
added
kind/security
status/in-backlog
A dev will begin to work on your modifications soon
labels
Jul 10, 2019
16 tasks
kduret
suggested changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for that, but even if it's a cherry-pick, could you split it in 2 lines to avoid to exceed 120 characters ?
kduret
approved these changes
Jul 10, 2019
vhr
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just suggestions
sc979
force-pushed
the
MON-3968-escape-nagios-path-and-poller-id-master
branch
from
July 11, 2019 13:36
f5c81d9
to
a39c6d9
Compare
sc979
force-pushed
the
MON-3968-escape-nagios-path-and-poller-id-master
branch
from
July 12, 2019 07:53
a39c6d9
to
f445601
Compare
sc979
added a commit
that referenced
this pull request
Jul 15, 2019
* add escapeshellarg to fix CVE-2019-13024
sc979
added a commit
that referenced
this pull request
Jul 15, 2019
* add escapeshellarg to fix CVE-2019-13024
sc979
added a commit
that referenced
this pull request
Jul 15, 2019
* add escapeshellarg to fix CVE-2019-13024
Succesfully cherry-picked on the branches :
|
lpinsivy
pushed a commit
that referenced
this pull request
Jul 15, 2019
* add escapeshellarg to fix CVE-2019-13024
lpinsivy
pushed a commit
that referenced
this pull request
Jul 15, 2019
* add escapeshellarg to fix CVE-2019-13024
sc979
added a commit
that referenced
this pull request
Jul 18, 2019
* add escapeshellarg to fix CVE-2019-13024
sc979
added a commit
that referenced
this pull request
Jul 18, 2019
* add escapeshellarg to fix CVE-2019-13024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
From @mhaskar 's PR https://github.com/centreon/centreon/pull/7663 -> rebased and conflict resolved.
PR already reviewed !
To be cherry-picked on the 18.10.x and 19.04.x branches after QA validation. For 2.8.x, an other PR is needed.
https://shells.systems/centreon-v19-04-remote-code-execution-cve-2019-13024
Fixes # (CVE)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team
Centreon team only