Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(widget) fix preference #7641

Merged
merged 1 commit into from
Jun 26, 2019
Merged

fix(widget) fix preference #7641

merged 1 commit into from
Jun 26, 2019

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Jun 20, 2019

Pull Request Template

Description

backport #7104 for 2.8

Widgets' preferences of some old widgets (in custom views) aren't modifiable without deleting them and creating new ones.
New widget's aren't affected.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979
Copy link
Contributor

sc979 commented Jun 20, 2019

What is this PR for ?
Could you add a short description ;)

@loiclau loiclau merged commit d55abe6 into 2.8.x Jun 26, 2019
@loiclau loiclau deleted the MON-3360-widget-preferences-2-8 branch June 26, 2019 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants