Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(remote-server): set task in failed status if an error appears #7634

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

lpinsivy
Copy link
Contributor

Description

Before if an error appears during import/export task process
The error was present into centcore.log file but the task was completed in database instead of the task status.
Now logs and task table will display failed status

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy
Copy link
Contributor Author

I moved the "move" export part and the STATE_COMPETED in the try to avoid this if an error appears
On my platform the indentation is ok

@lpinsivy lpinsivy requested a review from victorvassilev July 2, 2019 11:24
@adr-mo adr-mo force-pushed the MON-3927-improve-error-management branch from 4df3ee8 to ea1d370 Compare July 3, 2019 09:16
@lpinsivy lpinsivy merged commit 0392cb9 into master Jul 4, 2019
@lpinsivy lpinsivy deleted the MON-3927-improve-error-management branch July 4, 2019 11:34
lpinsivy added a commit that referenced this pull request Jul 4, 2019
lpinsivy added a commit that referenced this pull request Jul 4, 2019
lpinsivy added a commit that referenced this pull request Jul 4, 2019
…ort/export (#7634)

Conflicts:
	src/Centreon/Domain/Entity/Task.php
lpinsivy added a commit that referenced this pull request Jul 4, 2019
…ort/export (#7634)

Conflicts:
	src/Centreon/Domain/Entity/Task.php
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants