Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3807 service disabled filter #7612

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Jun 13, 2019

Pull Request Template

Description

In the web interface : Configuration > Services > Services by host/ host group.
When selecting "Disabled" in the status dropdown and clicking 'Search' the filter does not applies and the dropdown is reset.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@loiclau loiclau merged commit 64ec216 into 19.04.x Jun 18, 2019
loiclau added a commit that referenced this pull request Jun 18, 2019
* fix(filter) fix status filter for services by host
* fix(filter) fix status filter for services by host group
loiclau added a commit that referenced this pull request Jun 18, 2019
* fix(filter) fix status filter for services by host
* fix(filter) fix status filter for services by host group
@loiclau loiclau deleted the MON-3807-service-disabled-filter branch June 18, 2019 14:45
@quanghungb quanghungb mentioned this pull request Jul 3, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants