This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
enh(BE): optimizing the data sent when importing contact #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
force-pushed
the
MON-3871-remove-useless-LDAP-data-sent-to-back-end
branch
from
62df334 to
639600d
Compare
sc979
commented
May 23, 2019
| $arrayToReturn = array(); | ||
| foreach ($_POST["contact_select"] as $key => $subKey) { | ||
| $arrayToKeep[$key] = array_intersect_key($_POST["contact_select"][$key], $selectedUsers); | ||
| $arrayToReturn += $arrayToKeep; |
There was a problem hiding this comment.
I didn't use intentionally array_merge to avoid performance issues, as I add arrays in an array to be returned
kduret
approved these changes
May 23, 2019
sc979
changed the title
sc979
changed the title
callapa
approved these changes
May 23, 2019
sc979
force-pushed
the
MON-3871-remove-useless-LDAP-data-sent-to-back-end
branch
2 times, most recently
from
6b49393 to
f1aa746
Compare
|
branch rebased on the 19.04.x |
sc979
force-pushed
the
MON-3871-remove-useless-LDAP-data-sent-to-back-end
branch
from
f1aa746 to
252efb3
Compare
sc979
added a commit
that referenced
this pull request
Jun 3, 2019
sc979
added a commit
that referenced
this pull request
Jun 3, 2019
lpinsivy
pushed a commit
that referenced
this pull request
Jun 6, 2019
* enh(BE): optimizing the data sent when importing data * renaming variable and removing useless steps * udpating the composer.lock * fix(ldap): login after manual import
miteto
pushed a commit
that referenced
this pull request
Jun 7, 2019
* enh(BE): optimizing the data sent when importing data * renaming variable and removing useless steps * udpating the composer.lock * fix(ldap): login after manual import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Remove useless LDAP data sent to BE when importing contacts.
Please check the description and screenshots on ticket MON-3871
Fixes # (none)
Type of change
Target serie
How this pull request can be tested ?
Please check the ticket MON-3871 for screenshots
Checklist