Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

(fix) MySQL strict mode issues #7544

Merged
merged 5 commits into from
May 28, 2019
Merged

(fix) MySQL strict mode issues #7544

merged 5 commits into from
May 28, 2019

Conversation

lgcosta
Copy link
Contributor

@lgcosta lgcosta commented May 17, 2019

Pull Request Template

Description

SQL code changes needed to maintain compatibility with MySQL/MariaDB/Percona strict mode

With cooperation of this PR #7529 (thanks @leblanc-simon)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Using a version of Mariadb above 10.3.x or enable the strict mode in the server, more information:

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979
Copy link
Contributor

sc979 commented May 17, 2019

@lgcosta ,
Please, could you replace the :

  • intval($XXX) with (int)$XXX
  • fetchRow() with fetch()
  • DBRESULT with dbResult
    Thanks
    sc979

@lgcosta
Copy link
Contributor Author

lgcosta commented May 17, 2019

@lgcosta ,
Please, could you replace the :

  • intval($XXX) with (int)$XXX
  • fetchRow() with fetch()
  • DBRESULT with dbResult
    Thanks
    sc979

I will review and align all of these dbfunction.php with this formatting and any other codestyle that has to change.

Thanks

@lgcosta lgcosta changed the title WP: (fix) MySQL strict mode issues (fix) MySQL strict mode issues May 21, 2019
@lgcosta lgcosta changed the title (fix) MySQL strict mode issues WP: (fix) MySQL strict mode issues May 21, 2019
@lgcosta lgcosta changed the title WP: (fix) MySQL strict mode issues (fix) MySQL strict mode issues May 22, 2019
@ganoze ganoze merged commit 5d67bbe into master May 28, 2019
@ganoze ganoze deleted the strict_issues branch May 28, 2019 09:24
@leblanc-simon
Copy link
Contributor

Hi @ganoze , there is any chance to view this PR merged into 18.10 branch ?

@ganoze
Copy link
Contributor

ganoze commented May 29, 2019

@leblanc-simon Unfortunately no. The 18.10 release serie is not compatible with MariaDB strict mode and we only release bugfixes for released versions. So this PR and the MariaDB strict mode compatibility will make it in the 19.10 serie that will be released in October.

@leblanc-simon
Copy link
Contributor

OK, thanks for all

@lpinsivy
Copy link
Contributor

lpinsivy commented Jun 3, 2019

Replace : #6809

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants