Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3798 select2 previous search behavior #7525

Merged
merged 4 commits into from
May 15, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented May 7, 2019

Pull Request Template

Description

  • Correct the displayed saved researched value in the select2 components.

out of scope :

  • correct undefined variable in the logs when opening the downtime form
  • minor style correction

Fixes # (issue)

Type of change

  • [] Patch fixing an issue (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Open a form using a select2 filter.
Enter three letters of the name to be searched.
Select the occurence.
The popin should close.
Reopen the filter by clicking on it, your last research should be fully diplayed, and the select2 should display the other occurences available.

Checklist

  • I followed the coding style guidelines provided by Centreon
  •  I have rebased my development branch on the base branch (master, maintenance).
  • I have made sure that the unit tests related to the story are successful.

@sc979 sc979 requested review from leoncx and loiclau May 7, 2019 14:32
@sc979 sc979 merged commit a52d40f into master May 15, 2019
@sc979 sc979 deleted the MON-3798-select2-previous-search-behavior branch May 15, 2019 09:58
sc979 added a commit that referenced this pull request May 15, 2019
* enh(logs): remove undefined variable in downtime list page
* style: minor corrections
* fix(ui): saved select2 research field's value size
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants