This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Mon 3801 csv export acl #7517
Merged
Mon 3801 csv export acl #7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
force-pushed
the
MON-3801-csv-export-acl
branch
from
8d9dbf0 to
750b807
Compare
callapa
suggested changes
May 6, 2019
www/include/reporting/dashboard/csvExport/csv_HostGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_HostGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_HostGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_ServiceGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_ServiceGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_ServiceGroupLogs.php
Outdated
Show resolved
Hide resolved
loiclau
approved these changes
May 7, 2019
callapa
suggested changes
May 7, 2019
www/include/reporting/dashboard/csvExport/csv_HostGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_ServiceGroupLogs.php
Outdated
Show resolved
Hide resolved
sc979
force-pushed
the
MON-3801-csv-export-acl
branch
from
e608511 to
a02a410
Compare
sc979
force-pushed
the
MON-3801-csv-export-acl
branch
from
a02a410 to
05c3a91
Compare
callapa
suggested changes
May 9, 2019
www/include/reporting/dashboard/csvExport/csv_HostGroupLogs.php
Outdated
Show resolved
Hide resolved
www/include/reporting/dashboard/csvExport/csv_ServiceGroupLogs.php
Outdated
Show resolved
Hide resolved
sc979
force-pushed
the
MON-3801-csv-export-acl
branch
2 times, most recently
from
19f7ed1 to
9c58dc0
Compare
callapa
approved these changes
May 10, 2019
sc979
force-pushed
the
MON-3801-csv-export-acl
branch
from
9c58dc0 to
d319319
Compare
sc979
added a commit
that referenced
this pull request
May 15, 2019
* fix(acl): export hostgroup CSV * fix(acl): export host CSV * fix(acl): export servicegroup CSV * fix(acl): export service CSV * fix(csv): undefined variable when exporting datas
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fix ACL calculation when interfering with the GET request
Fixes # (support)
Type of change
Target serie
How this pull request can be tested ?
For more details, please ask me in private
Checklist
I followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have rebased my development branch on the base branch (master, maintenance).
I have made sure that the unit tests related to the story are successful.
I have made sure that unit tests covers 80% of the code written for the story.
I have made sure that acceptance tests related to the story are successful (local and CI)