Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(monitoring service): Fix hard_state_duration column #7506

Merged

Conversation

callapa
Copy link
Contributor

@callapa callapa commented Apr 30, 2019

Fixed statusFilter that changed before the xls call was completed.
Fixed the xls file to display the hard_state_duration column only when the state filter is 'ok' or 'pending'.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x (master)

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

Fixed the xls file to display the hard_state_duration column only when the state filter is 'ok' or 'pending'.
www/include/monitoring/status/Services/service.php Outdated Show resolved Hide resolved
www/include/monitoring/status/Services/service.php Outdated Show resolved Hide resolved
www/include/monitoring/status/Services/service.php Outdated Show resolved Hide resolved
www/include/monitoring/status/Services/service.php Outdated Show resolved Hide resolved
www/include/monitoring/status/Services/xml/serviceXML.php Outdated Show resolved Hide resolved
callapa and others added 2 commits April 30, 2019 16:37
@callapa callapa requested a review from sc979 April 30, 2019 14:58
Co-Authored-By: callapa <lcalvet@centreon.com>
@loiclau loiclau mentioned this pull request May 3, 2019
12 tasks
@callapa callapa force-pushed the MON-3742_Fix_hard_state_duration_in_monitoring_service branch from 1e47530 to 9141ed0 Compare May 6, 2019 08:42
@callapa callapa merged commit 1fa64fd into master May 7, 2019
@callapa callapa deleted the MON-3742_Fix_hard_state_duration_in_monitoring_service branch May 7, 2019 09:30
loiclau pushed a commit that referenced this pull request May 10, 2019
Fixed statusFilter that changed before the xls call was completed.
Fixed the xls file to display the hard_state_duration column only when the state filter is 'ok' or 'pending'.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants