Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(status details): Fix a double webservice call #7483

Merged
merged 1 commit into from
May 7, 2019

Conversation

callapa
Copy link
Contributor

@callapa callapa commented Apr 24, 2019

Description

When the option for one of the Poller, Servicegroup, or Hostgroup groups is selected, a double Webservice call is performed.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Open de debug tab in your webrowser. In the debug tab select the network tab and change option from one of these lists: Poller, Hostgroup, Servicegroup.
For each change, only one webservice call is performed.

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@loiclau loiclau mentioned this pull request May 3, 2019
12 tasks
@callapa callapa merged commit 736401e into master May 7, 2019
@callapa callapa deleted the MON-3779_Fix_double_webservice_call branch May 7, 2019 09:25
loiclau pushed a commit that referenced this pull request May 10, 2019
Fix a double webservice call when the option for one of the Poller, Servicegroup, or Hostgroup groups is selected.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants