-
Notifications
You must be signed in to change notification settings - Fork 240
fix(widget) : widget params on public view #7408
Conversation
you can test this pull request by creating a new view with various widgets on it and configure them so that they do not show the default data and/or the warning message telling you ton configure them. When done, just make your view public so that people can add this view to their home page. Switch to another user, try to load the public view, you'll notice that every single widget in the view is not configured. this fixes #7320 and #7383 |
40d943a
to
43b85e4
Compare
43b85e4
to
cc6190e
Compare
correctly set widget params when you load a public view
cc6190e
to
48c9019
Compare
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
from : fix(widget) : widget params on public view #7383 * correctly set widget params when you load a public view * enh : check if $userId is non empty
Pull Request Template
Description
If the view is being added for the first time, we make sure that the widget parameters are going to be set
Get all widget's parameters from the view that is being added and add every widget parameters to the current user
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
you can test this pull request by creating a new view with various widgets on it and configure them so that they do not show the default data and/or the warning message telling you ton configure them.
When done, just make your view public so that people can add this view to their home page.
Switch to another user, try to load the public view, you'll notice that every single widget in the view is not configured.
this fixes #7320 and #7383
I've forgot to test what happens if the view creator made an unlocked sharing to a specific user and then someone adds this view from the public views list (i'm thinking about that because of the
locked=0
condition in the query (might want to change that foris_owner=1
. I'll test that later today and update the thread. (thx @tanguyvda )Checklist