Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(core): enhance logger lib to handle utf8, add possibility to pass… #7404

Closed
wants to merge 1 commit into from
Closed

enh(core): enhance logger lib to handle utf8, add possibility to pass… #7404

wants to merge 1 commit into from

Conversation

garnier-quentin
Copy link
Contributor

… connection options to perl db lib

Pull Request Template

Description

  • Can use 'mysql_enable_utf8' for DBI connect
  • Can display correctly utf-8 (log file and terminal)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

You can test it with last version of centreon-auto-discovery-server for example:

  • create an host with characters like: centreonétest
  • try to check it with following command: perl centreon_autodisco.pl --filter-host="centreonétest"

It should do the discovery rule.

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@adr-mo
Copy link
Contributor

adr-mo commented Apr 12, 2019

Merged on master and 18.10.x

@adr-mo adr-mo closed this Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants