Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3659 mediawiki configuration and pagination #7397

Merged
merged 6 commits into from
Apr 12, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Apr 9, 2019

Pull Request Template

Description

  • Pagination and filters fix for the "configuration > knowledgeBase" pages

  • fix the broken serviceTemplate's wikiURL

  • correct the getServiceId() method's query

  • replace $oreon with $centreon

  • style, psr2 and license update

  • remove the php notice array to string conversion in the htmlHeader.php file

  • fix $o in the ternary of the common/pagination.php file

Type of change

  • Patch fixing an issue (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Save a filter and check that when you change the pagination filter, the filter fields aren't empty and the displayed results are what they should be

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  •  I have rebased my development branch on the base branch (master, maintenance).

@sc979 sc979 force-pushed the MON-3659-mediawiki-configuration-and-pagination branch from 289b69c to d739cf3 Compare April 9, 2019 13:40
@sc979 sc979 force-pushed the MON-3659-mediawiki-configuration-and-pagination branch from d739cf3 to 74956c0 Compare April 10, 2019 08:06
www/main.get.php Outdated Show resolved Hide resolved
@sc979 sc979 force-pushed the MON-3659-mediawiki-configuration-and-pagination branch 2 times, most recently from 3e7a613 to 07ab704 Compare April 10, 2019 11:57
@sc979 sc979 force-pushed the MON-3659-mediawiki-configuration-and-pagination branch from 07ab704 to ece581b Compare April 10, 2019 15:55
@adr-mo adr-mo force-pushed the MON-3659-mediawiki-configuration-and-pagination branch from ece581b to c377456 Compare April 12, 2019 13:01
@sc979 sc979 force-pushed the MON-3659-mediawiki-configuration-and-pagination branch from c377456 to f7d24d6 Compare April 12, 2019 21:02
@sc979 sc979 merged commit 68d7a11 into 18.10.x Apr 12, 2019
@sc979 sc979 deleted the MON-3659-mediawiki-configuration-and-pagination branch April 12, 2019 21:03
sc979 added a commit that referenced this pull request Apr 12, 2019
* fix(ui): pagination file of knowledge base
* enh(BE): replacing oreon with centreon
* fix(log): removing array to string conversion notice
* fix(KB): broken service template called url and undefined path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants