Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Fix watchdog option #7367

Closed
wants to merge 6 commits into from
Closed

Conversation

s-duret
Copy link
Contributor

@s-duret s-duret commented Apr 1, 2019

Pull Request Template

Description

I changed the default value for Centreon Broker logs path because it caused a lot of issues.
I also changed all the traduction files for this option.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

You have to go on Configuration > Collecteurs, click on a poller and check the option name.
You also have to generate the configuration and check the watchdog log path in /etc/centreon-broker/watchdog.xml.

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

lpinsivy
lpinsivy previously approved these changes Apr 3, 2019
@lpinsivy lpinsivy dismissed their stale review April 3, 2019 12:12

double

@adr-mo
Copy link
Contributor

adr-mo commented Apr 10, 2019

Hi,

The following branch has been created for the validation

MON-3669-broker-default-log-path

@adr-mo
Copy link
Contributor

adr-mo commented Apr 10, 2019

Hi @s-duret

Validation is OK

Commits were reworked and merged on

Regards,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants