Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3561 hosts configuration and pagination #7348

Merged
merged 16 commits into from
Apr 5, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Mar 28, 2019

Pull Request Template

Description

Correct saved pagination filter and history filters

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

on the configuration > hosts > any page,
in the list -> choose some filters in the dedicated fields,
move to a form -> the filters should be saved (including the pagination filter)
if you navigate in the menus and come back to this page -> all filters should be restored as you set them, except for the pagination, which should return to the first page

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 force-pushed the MON-3561-hosts-configuration-and-pagination branch from 9ab09ce to e1f3300 Compare March 28, 2019 16:19
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time, use @var annotation ;)

@sc979 sc979 force-pushed the MON-3561-hosts-configuration-and-pagination branch 7 times, most recently from d6dd1ef to 8788f72 Compare April 3, 2019 11:16
sc979 and others added 14 commits April 4, 2019 17:16
* fix(ui): saving configuration > services by host filters
* fix(ui): saving configuration > services by hostgroups filters
* fix(ui): saving configuration > servicesgroups filters
* fix(ui): saving configuration > service template filters
* fix(ui): saving configuration > service categories filters
* fix(ui): saving configuration > meta services filters
* fix(ui): saving configuration > contact users filters
* fix(ui): saving configuration > contact template filters
* fix(ui): saving configuration > contactgroup filters
* fix(ui): saving configuration > timeperiod filters
* fix(ui): saving configuration > commands checks filter
* fix(ui): replace the lastPage array with a string for the pagination filters
* fix(ui): saving configuration > other command pages filters
* fix(ui): configuration > poller > engine configuration
* fix(ui): configuration > resources
* fix(ui): configuration > pollers
* fix(ui): configuration > escalations
* fix(ui): configuration > host dependency
* fix(ui): configuration > hostgroup dependency
* fix(ui): configuration > servicegroup dependency
* fix(ui): configuration > service dependency
* fix(ui): configuration > meta service dependency
* fix(ui): configuration > centreon-broker
* fix(ui): configuration > traps
* fix(ui): configuration > trap manufacturer
* fix(ui): configuration > trap groups
@sc979 sc979 force-pushed the MON-3561-hosts-configuration-and-pagination branch from 8788f72 to e0fd959 Compare April 4, 2019 15:16
@sc979 sc979 merged commit ff56af4 into 18.10.x Apr 5, 2019
sc979 added a commit that referenced this pull request Apr 5, 2019
* fix(ui): saving configuration > hosts filters (#7348 )
* fix(ui): setting current pagination from history
* fix(ui): saving configuration > hosts filters
* fix(ui): saving configuration > hostgroups filter
* fix(ui): saving configuration > hostTemplate filters
* fix(ui): saving configuration > hostCategories filter

* fix(ui): saving configuration > services filters (#7355)
* fix(ui): saving configuration > services by host filters
* fix(ui): saving configuration > services by hostgroups filters
* fix(ui): saving configuration > servicesgroups filters
* fix(ui): saving configuration > service template filters
* fix(ui): saving configuration > service categories filters
* fix(ui): saving configuration > meta services filters

* fix(ui): saving configuration > contacts filters (#7360)
* fix(ui): saving configuration > contact users filters
* fix(ui): saving configuration > contact template filters
* fix(ui): saving configuration > contactgroup filters
* fix(ui): saving configuration > timeperiod filters

* fix(ui): saving configuration > commands filters (#7369)
* fix(ui): saving configuration > commands checks filter
* fix(ui): saving configuration > other command pages filters

* fix(ui): saving configuration > poller and other menus filters (#7375)
* fix(ui): configuration > poller > engine configuration
* fix(ui): configuration > resources
* fix(ui): configuration > pollers
* fix(ui): configuration > escalations
* fix(ui): configuration > host dependency
* fix(ui): configuration > hostgroup dependency
* fix(ui): configuration > servicegroup dependency
* fix(ui): configuration > service dependency
* fix(ui): configuration > meta service dependency
* fix(ui): configuration > centreon-broker
* fix(ui): configuration > traps
* fix(ui): configuration > trap manufacturer
* fix(ui): configuration > trap groups

* fix(ui): pagination feedbacks from validation process
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants