This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
Mon 3561 hosts configuration and pagination #7348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
force-pushed
the
MON-3561-hosts-configuration-and-pagination
branch
from
March 28, 2019 16:19
9ab09ce
to
e1f3300
Compare
kduret
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next time, use @var annotation ;)
miteto
approved these changes
Mar 29, 2019
4 tasks
sc979
force-pushed
the
MON-3561-hosts-configuration-and-pagination
branch
7 times, most recently
from
April 3, 2019 11:16
d6dd1ef
to
8788f72
Compare
* fix(ui): saving configuration > services by host filters * fix(ui): saving configuration > services by hostgroups filters * fix(ui): saving configuration > servicesgroups filters * fix(ui): saving configuration > service template filters * fix(ui): saving configuration > service categories filters * fix(ui): saving configuration > meta services filters
* fix(ui): saving configuration > contact users filters * fix(ui): saving configuration > contact template filters * fix(ui): saving configuration > contactgroup filters * fix(ui): saving configuration > timeperiod filters
* fix(ui): saving configuration > commands checks filter * fix(ui): replace the lastPage array with a string for the pagination filters * fix(ui): saving configuration > other command pages filters
* fix(ui): configuration > poller > engine configuration * fix(ui): configuration > resources * fix(ui): configuration > pollers * fix(ui): configuration > escalations * fix(ui): configuration > host dependency * fix(ui): configuration > hostgroup dependency * fix(ui): configuration > servicegroup dependency * fix(ui): configuration > service dependency * fix(ui): configuration > meta service dependency * fix(ui): configuration > centreon-broker * fix(ui): configuration > traps * fix(ui): configuration > trap manufacturer * fix(ui): configuration > trap groups
sc979
force-pushed
the
MON-3561-hosts-configuration-and-pagination
branch
from
April 4, 2019 15:16
8788f72
to
e0fd959
Compare
sc979
added a commit
that referenced
this pull request
Apr 5, 2019
* fix(ui): saving configuration > hosts filters (#7348 ) * fix(ui): setting current pagination from history * fix(ui): saving configuration > hosts filters * fix(ui): saving configuration > hostgroups filter * fix(ui): saving configuration > hostTemplate filters * fix(ui): saving configuration > hostCategories filter * fix(ui): saving configuration > services filters (#7355) * fix(ui): saving configuration > services by host filters * fix(ui): saving configuration > services by hostgroups filters * fix(ui): saving configuration > servicesgroups filters * fix(ui): saving configuration > service template filters * fix(ui): saving configuration > service categories filters * fix(ui): saving configuration > meta services filters * fix(ui): saving configuration > contacts filters (#7360) * fix(ui): saving configuration > contact users filters * fix(ui): saving configuration > contact template filters * fix(ui): saving configuration > contactgroup filters * fix(ui): saving configuration > timeperiod filters * fix(ui): saving configuration > commands filters (#7369) * fix(ui): saving configuration > commands checks filter * fix(ui): saving configuration > other command pages filters * fix(ui): saving configuration > poller and other menus filters (#7375) * fix(ui): configuration > poller > engine configuration * fix(ui): configuration > resources * fix(ui): configuration > pollers * fix(ui): configuration > escalations * fix(ui): configuration > host dependency * fix(ui): configuration > hostgroup dependency * fix(ui): configuration > servicegroup dependency * fix(ui): configuration > service dependency * fix(ui): configuration > meta service dependency * fix(ui): configuration > centreon-broker * fix(ui): configuration > traps * fix(ui): configuration > trap manufacturer * fix(ui): configuration > trap groups * fix(ui): pagination feedbacks from validation process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Correct saved pagination filter and history filters
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
on the configuration > hosts > any page,
in the list -> choose some filters in the dedicated fields,
move to a form -> the filters should be saved (including the pagination filter)
if you navigate in the menus and come back to this page -> all filters should be restored as you set them, except for the pagination, which should return to the first page
Checklist
Community contributors & Centreon team
Centreon team only