This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Mon 3570 filter status #7345
Merged
Mon 3570 filter status #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2019 16:13
- check dropdown from $_GET parameters and use it - remove duplicated parameters from form - check if parameter is string when adding it to parameters in URL (for redirecting)
…in order to set proper status service dropdown
vhr
approved these changes
Mar 28, 2019
Co-Authored-By: miteto <miteto@miteto.net>
sc979
suggested changes
Mar 28, 2019
Co-Authored-By: miteto <miteto@miteto.net>
Co-Authored-By: miteto <miteto@miteto.net>
sc979
approved these changes
Mar 28, 2019
miteto
added a commit
that referenced
this pull request
Apr 5, 2019
* fix(monitoring filters): status filter dropdown doesn't lose it's value - check dropdown from $_GET parameters and use it - remove duplicated parameters from form - check if parameter is string when adding it to parameters in URL (for redirecting) * fix(coding style): fix spacing, use short PHP echo * fix(monitoring filters): use status service from URL instead of "_o" in order to set proper status service dropdown * Update www/include/core/header/header.php Co-Authored-By: miteto <miteto@miteto.net> * Update www/include/monitoring/status/Services/service.php Co-Authored-By: miteto <miteto@miteto.net> * Update www/include/monitoring/status/Services/service.php Co-Authored-By: miteto <miteto@miteto.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter status fix
Fix monitoring filters
Fixes 3570
Type of change
Target serie
How this pull request can be tested ?