This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(graph): display thresholds in Split chart mode #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2019
|
Hi @cpbn, Thanks for the contribution 💯 We'll try to make your work happen in Centreon as soon as possible 👍 Regards, |
loiclau
approved these changes
May 6, 2019
sc979
approved these changes
May 7, 2019
|
Creating a new branch from yours @cpbn to do the validation :) |
|
Perfect @adr-mo, feel free, many thx :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Description
This PR activates thresholds display on graphs when in Split chart mode, so when there is only one curve per graph.
Fixes #7342
Should also close #7235.
Type of change
Target serie
How this pull request can be tested ?
Display a graph with several curves, and with at least with thresholds.
With all curves on the same graph, thresholds are not displayed.
Go in Split chart mode, and verify here that thresholds are correctly shown.
Thank you 👍