This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(graph): no-unit series now trigger a second axis #7341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cpbn, Thanks for the contribution 💯 We'll try to make your work happen in Centreon as soon as possible 👍 Regards, |
loiclau
approved these changes
May 9, 2019
|
Many thanks @loiclau 👍 |
kduret
approved these changes
May 13, 2019
loiclau
pushed a commit
that referenced
this pull request
May 16, 2019
|
Hi, thanks for the contribution |
|
Hi @loiclau, and many thanks for having merged this 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Description
Issue is detailed in #7330.
This PR solves it making no-unit series having their own y-axis.
Leading to this beautiful graph example :
Fixes #7330
Type of change
Target serie
How this pull request can be tested ?
As detailed in #7330, generate graphs with several series, some with a unit, some without unit.
Be then sure that series without unit are on their own y-axis.
Thank you 👍