Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(ui): do not display autologin shortcut when disabled #7340

Merged
merged 4 commits into from
Sep 20, 2019
Merged

fix(ui): do not display autologin shortcut when disabled #7340

merged 4 commits into from
Sep 20, 2019

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Mar 26, 2019 •
edited
Loading

Pull Request Template

Description

As a Centreon User
When I disable the auto login shortcut in "Administration -> Parameters -> Centreon UI"
Then it is not displayed in the user menu from top counter

There is other cases to handle than the one that does not work currently.

Use cases to validate

  • If the auto login is enabled, user has defined the auto login token and the option to hide the auto login key is enabled => The button is NOT displayed.
  • If the auto login is enabled, user has defined the auto login token and the option to hide the auto login key is disabled => The button is displayed.
  • If the auto login is enabled, user has NOT defined the auto login token => The button is NOT displayed
  • If the auto login is disabled, user has defined the auto login token and the option => The button is NOT displayed
  • If the auto login is disabled, user has NOT defined the auto login token and the option => The button is NOT displayed

Fixes #7331

Type of change

  • Patch fixing an issue (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Please check the description of the Pull Request

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@adr-mo adr-mo requested a review from kduret March 26, 2019 20:16
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from dbe8792 to af1b546 Compare April 12, 2019 11:36
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from af1b546 to 3f3450d Compare April 25, 2019 20:30
sc979
sc979 suggested changes Jul 10, 2019
View reviewed changes
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from 3f3450d to 4b9759e Compare July 10, 2019 12:05
@adr-mo adr-mo requested a review from sc979 July 10, 2019 12:06
@adr-mo
Copy link
Contributor Author

adr-mo commented Jul 10, 2019

I've made the changes requested and rebased the branch @sc979

@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from 4b9759e to abbf66b Compare July 10, 2019 12:30
sc979
sc979 suggested changes Jul 10, 2019
View reviewed changes
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch 3 times, most recently from 7f26560 to 2559de4 Compare July 10, 2019 13:03
@adr-mo adr-mo requested a review from sc979 July 10, 2019 13:04
sc979
sc979 suggested changes Jul 10, 2019
View reviewed changes
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
www/api/class/centreon_topcounter.class.php Outdated Show resolved Hide resolved
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from 2559de4 to eedfc9c Compare July 10, 2019 13:32
@adr-mo adr-mo force-pushed the MON-3624-autologin-shortcut-issue branch from eedfc9c to 184954b Compare July 10, 2019 13:58
@adr-mo adr-mo requested a review from kduret July 10, 2019 13:59
@UrBnW
Copy link
Contributor

UrBnW commented Sep 6, 2019

Still facing this small issue in 19.10.0-beta.2.
Perhaps we could then merge this tiny fix.
Thank you 👍

@lpinsivy lpinsivy added area/acl kind/bug status/in-backlog A dev will begin to work on your modifications soon labels Sep 9, 2019
@adr-mo adr-mo changed the base branch from 18.10.x to 19.04.x September 9, 2019 13:47
@adr-mo adr-mo changed the base branch from 19.04.x to 18.10.x September 9, 2019 13:47
@kduret kduret merged commit b5de5be into 18.10.x Sep 20, 2019
@kduret kduret deleted the MON-3624-autologin-shortcut-issue branch September 20, 2019 12:12
kduret pushed a commit that referenced this pull request Sep 20, 2019
@adr-mo @kduret
fix(ui): do not display autologin shortcut when disabled (#7340)
ccfbfcc
kduret pushed a commit that referenced this pull request Sep 20, 2019
@adr-mo @kduret
fix(ui): do not display autologin shortcut when disabled (#7340)
55a7cfa
@UrBnW UrBnW mentioned this pull request Oct 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sc979 sc979 sc979 approved these changes

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
area/acl kind/bug status/in-backlog A dev will begin to work on your modifications soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adr-mo @UrBnW @kduret @sc979 @lpinsivy