Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(ceip): Add additional statistics including modules if present #7328

Merged
merged 4 commits into from
Apr 9, 2019

Conversation

lpinsivy
Copy link
Contributor

@lpinsivy lpinsivy commented Mar 22, 2019

Description

Add more CEIP statistics:

  • Add usage of widgets in custom views
  • Send OS name and version
  • Check if a module can provides additional statistics

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

Please delete series that are not relevant.

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Check data sent

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy lpinsivy force-pushed the ceip-improve-statistics branch 2 times, most recently from f36eafb to a130df5 Compare March 25, 2019 10:12
@lpinsivy lpinsivy force-pushed the ceip-improve-statistics branch from a130df5 to 028861e Compare March 25, 2019 12:09
sc979
sc979 previously approved these changes Apr 3, 2019
Copy link
Contributor

@callapa callapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some coding style errors and bad coding practices.
Be careful when copying / pasting code.

www/class/centreonStatsModules.class.php Outdated Show resolved Hide resolved
www/class/centreonStatsModules.class.php Outdated Show resolved Hide resolved
www/class/centreonStatsModules.class.php Outdated Show resolved Hide resolved
www/class/centreonStatsModules.class.php Show resolved Hide resolved
www/class/centreonStatsModules.class.php Outdated Show resolved Hide resolved
www/class/centreonStatsModules.class.php Outdated Show resolved Hide resolved
@sc979
Copy link
Contributor

sc979 commented Apr 3, 2019

@callapa , you're right, I should have been more careful

@sc979 sc979 dismissed their stale review April 3, 2019 17:10

...

fix(coding): correct coding style
@lpinsivy lpinsivy force-pushed the ceip-improve-statistics branch from 450b875 to 398a724 Compare April 4, 2019 10:27
@lpinsivy lpinsivy requested review from callapa and sc979 April 4, 2019 10:28
@lpinsivy lpinsivy merged commit 71606fb into master Apr 9, 2019
@lpinsivy lpinsivy deleted the ceip-improve-statistics branch April 9, 2019 09:05
lpinsivy added a commit that referenced this pull request Apr 9, 2019
)

* enh(ceip): Add additional statistics including modules if present
* enh(doc): add statistics modules & widgets usage
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants