This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
enh(ceip): Add additional statistics including modules if present #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinsivy
commented
Mar 22, 2019
lpinsivy
force-pushed
the
ceip-improve-statistics
branch
2 times, most recently
from
March 25, 2019 10:12
f36eafb
to
a130df5
Compare
lpinsivy
force-pushed
the
ceip-improve-statistics
branch
from
March 25, 2019 12:09
a130df5
to
028861e
Compare
sc979
previously approved these changes
Apr 3, 2019
callapa
suggested changes
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some coding style errors and bad coding practices.
Be careful when copying / pasting code.
sc979
reviewed
Apr 3, 2019
sc979
reviewed
Apr 3, 2019
sc979
reviewed
Apr 3, 2019
@callapa , you're right, I should have been more careful |
fix(coding): correct coding style
lpinsivy
force-pushed
the
ceip-improve-statistics
branch
from
April 4, 2019 10:27
450b875
to
398a724
Compare
callapa
approved these changes
Apr 5, 2019
sc979
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more CEIP statistics:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Target serie
Please delete series that are not relevant.
How this pull request can be tested ?
Check data sent
Checklist
Community contributors & Centreon team
Centreon team only