fix(ldap): sql errors in the log on authentication #7278

sc979 · 2019-03-14T12:18:23Z

LDAP SQL errors in the logs

Description

Fixes # (issue): support

Type of change

Cleaning code
Fixing : "Undefined index: contact_passwd" in php logs
Fixing: "QUERY : SELECT contact_id FROM contact WHERE contact_ldap_dn IN ()" in sql logs

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

18.10.x
19.04.x (master)

How this pull request can be tested ?

When importing an user from the LDAP, you should find these errors before applying the fix.

Checklist

Community contributors & Centreon team

I followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified.
I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

I have made sure that the unit tests related to the story are successful.
I have made sure that unit tests covers 80% of the code written for the story.
I have made sure that acceptance tests related to the story are successful (local and CI)

www/class/centreonContactgroup.class.php

all changes have been done

* enh(ldap): optimize ldap sync at config generation (Fix #6949) * fix(log): removing ldap error on password * fix(log): removing ldap error when no dnContact found * fix(ldap): error when no default contactgroup was chosen * fix(ldap): broken PDO when the value is null * enh(ldap): adding more precise error messages and commenting code

sc979 force-pushed the MON-3529-sql-error-on-ldap-authentication branch from 33baa2b to a3523d2 Compare March 15, 2019 10:58

kduret approved these changes Mar 18, 2019

View reviewed changes