This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
enh(ui) : better delimitation of menu #7253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaL87
approved these changes
Mar 6, 2019
sc979
previously approved these changes
Mar 6, 2019
sc979
dismissed
their stale review
this PR isn't properly rebased. As it merges the code from another PR when it shouldn't : https://github.com/centreon/centreon/pull/7251
sc979
suggested changes
Mar 6, 2019
| @@ -395,7 +396,7 @@ a { | |||
| font-size: 0.8rem; | |||
| background-color: $white-color; | |||
| display: block; | |||
| padding: 3px 10px 3px 47px; | |||
| padding: 3px 10px 3px 56px; | |||
There was a problem hiding this comment.
this modification is from another PR not yet approved by the QA : https://github.com/centreon/centreon/pull/7251
| // color: $white-color; | ||
| // background-color: #0a78a5; | ||
| // } | ||
| padding: 8px 10px 8px 56px; |
There was a problem hiding this comment.
this modification is from another PR not yet approved by the QA : https://github.com/centreon/centreon/pull/7251
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:
You should see a grey border on the right side of the left menu.
Type of change
Please delete options that are not relevant.
Target serie
You should see a grey border on the right side of the left menu.
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team
* updating the release note results in adding the pull request id and description at the end of the file. Product Managers will rework it for the release. Release notes can be found here.
Centreon team only