This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
feat(remote-server): allow usage of domain names #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to define remote server by address not only by IP Resolves MON-3257
victorvassilev
requested review from
kduret and
vhr
and removed request for
kduret
vhr
approved these changes
Mar 6, 2019
| @@ -36,13 +35,21 @@ class NotifyMasterService | |||
| private $curl; | |||
|
|
|||
| /** | |||
| * @return Curl | |||
| * @return void | |||
There was a problem hiding this comment.
just remove a return annotation
| /* | ||
| * resolve the address down to IP | ||
| */ | ||
| $ipAddress = gethostbyname($ip); |
There was a problem hiding this comment.
maybe this preparation should be done before IP is pass to the repository method
victorvassilev
added a commit
that referenced
this pull request
Mar 22, 2019
* feat(remote-server): allow usage of domain names Allows the user to define remote server by address not only by IP Resolves MON-3257 * add validator change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the user to define remote server by address not only by IPFixes # MON-3257
Type of change
Please delete options that are not relevant.
Target serie
- [ x] 18.10.x