Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(secu): rce vulnerability when using command's testing feature #7230

Closed
wants to merge 3 commits into from

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Feb 26, 2019

Original author : @gquere
Adding : bindValue methods to prevent SQL injection and PSR2

Authenticated RCE

An RCE was exploitable in minPlayCommand.php

Fixes # (issue) : none

Type of change

  • Patch fixing an issue (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Ask me in private please.

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon.
  • I have rebased my development branch on the base branch (master, maintenance).
  • I have updated the release note in dedicated temporary section. *
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979
Copy link
Contributor Author

sc979 commented Feb 26, 2019

I'm closing this PR, as I removed the author commit :'(

@sc979 sc979 closed this Feb 26, 2019
@sc979 sc979 deleted the MON-3310-authenticated-rce-minplay-command branch February 26, 2019 16:10
@sc979
Copy link
Contributor Author

sc979 commented Feb 26, 2019

Here's the new PR :
https://github.com/centreon/centreon/pull/7232

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant